Prevent number_format() from returning negative zero
- Currently implemented
- Target version: 7.2
- Approved at 93.3%
PHP RFC: Prevent number_format() from returning negative zero
- Version: 0.1
- Date: 2017-04-01
- Author: Craig Duncan email@example.com
- Proposed version: PHP 7.2
- Status: Implemented (in PHP 7.2)
string(1) “0”, however calling
number_format() is commonly used for formatting numbers for human-readable display, this behaviour is unexpected.
This RFC proposes keeping
number_format() consistent and not displaying the sign when a number is rounded to zero.
There was an argument that all floating point logic in PHP follows IEEE 754, where negative zero is valid.
number_format() already prevents negative zero, so this isn't the case.
Backward Incompatible Changes
This change has BC concerns for anybody relying on the current behaviour, but this is thought to be incredibly minor and not unrealistic for a point release.
Proposed PHP Version(s)
Pull request: https://github.com/php/php-src/pull/2508
An option needs 50%+1 votes to win